guyromb / cordova-open-native-settings

Plugin to open native screens of iOS/android settings (maintained, end-2020)
http://gsrweb.net
MIT License
113 stars 105 forks source link

Wrong engines in package.json #26

Closed timbru31 closed 6 years ago

timbru31 commented 6 years ago

The package.json defines cordova as an engine (https://github.com/guyromb/Cordova-open-native-settings/blob/master/package.json#L22-L25), the nowadays recommended way is to define cordova engines like the following:

"engines": {
    "cordovaDependencies": {
        PLUGIN_VERSION: {
            DEPENDENCY: SEMVER_RANGE,
            DEPENDENCY: SEMVER_RANGE,
            ...
        },
        ...
    }
}

For more information see https://cordova.apache.org/docs/en/7.x/guide/hybrid/plugins/index.html#specifying-cordova-dependencies

guyromb commented 6 years ago

@timbru31 do you mind to update it to the new structure and make a pull request? I'll gladly merge it. thanks

timbru31 commented 6 years ago

Yes, I'll try to do one later today. 👍

timbru31 commented 6 years ago

Took me longer than one day, but I created a PR 👍

guyromb commented 6 years ago

Awesome @timbru31 !