Closed niktekusho closed 3 weeks ago
Hey @niktekusho,
Thanks a lot for using these images!
The healthcheck documentation in the ReadMe is for a GitHub Actions yaml file, not for Docker compose. According to the Docker compose reference, however, a similar healthcheck operation can be performed with something like this:
healthcheck:
test: ["CMD", "healthcheck.sh"]
interval: 10s
timeout: 5s
retries: 10
start_period: 5s
start_interval: 5s
Hope this helps!
Your solution worked wonders; thank you! Would you accept a PR that adds that bit to the docs? I was thinking about expanding the healthcheck section by mentioning the docker-compose syntax for future users.
Awesome, glad to hear that @niktekusho!
Yeah sure, PRs are always welcome, but I'm also happy to put the info into the ReadMe for you, up to you. :)
Merged and live!
Thanks a lot for your contribution, @niktekusho!
Hello, thank you for the awesome image.
Coming from a spring boot project with the
spring-boot-starter-data-jdbc
andspring-boot-docker-compose
dependencies, I'm noticing the spring boot application starts too fast for the Oracle container. The spring boot app bootstrap fails with "Unable to establish JDBC connections".From what I've read spring-boot-docker-compose should delay the application bootstrap until the containers defined in the compose.yml are up and running. My idea was to "artificially" delay the healthcheck of the oracle container so that it has more time to boot up.
Currently, in the README, there're the following lines:
https://github.com/gvenzl/oci-oracle-free/blob/b5decfee76b7d3b6898f3a4852f8dc1f159fbd4b/README.md?plain=1#L106-L111
which is not a valid compose syntax.
Is that
options
key supposed to behealthcheck
instead?If you have a better approach to solve this, please feel free to share ;)
Small sample
compose.yml
build.gradle