A Few Issues from the Last Few Months of Testing

gwatcha / reaper-keys

vim-bindings for Reaper

https://gwatcha.github.io/reaper-keys/

MIT License

144 stars 10 forks source link

A Few Issues from the Last Few Months of Testing #71

Closed jonch070 closed 3 weeks ago

jonch070 commented 4 months ago

Hey hey!! Thanks for all the work on this. I've been seriously working with reaper keys as a film composer for a few months and am trying to make it my daily driver. I've been discovering a few issues so I thought I would put them in one issue. Let me know if there is a better way/if you would like separate issues for all of these

OpenInMidiEditor does not focus on midi editor when open and instead tries to rename current track. Cannot figure out why this is the case, previous commits did not have this problem
Midi note movement horizontally not working, seems like there isn't focusing on midi note editor
Help file does not focus search bar when open (QOL)
In readme it says 0 = get to item start, but it is actually jump to start of project
Visual timeline mode behaviour not starting from cursor when engaged (AntoineBalaine has a fix in his fork's state.lua that has worked for me)

Thank you!

myrrc commented 4 months ago

Hi and thanks for reporting. 1 is fixed and I'm working on a test currently, as for other issues, I'll have a look

myrrc commented 3 months ago

Help file does not focus search bar when open (QOL) I didn't manage to reproduce the issue with binding window search bar. Can you record a screencast showing that it doesn't focus?

jonch070 commented 3 months ago

of course! you can see here that if i start typing when i bring up the binding window I still am triggering reaper keys commands in the arrange until i click into it binding list issue

myrrc commented 3 months ago

of course! you can see here that if i start typing when i bring up the binding window I still am triggering reaper keys commands in the arrange until i click into it

What's your system and reaper-keys revision? Maybe it's specific to macos / windows because I wasn't able to reproduce it on Linux so far

There is an issue, though, if binding window is opened when feedback is not (i.e. reaper-keys action is not running), filter/search options don't work.

jonch070 commented 3 months ago

mac os sonoma, hard to say what version of reaper keys im on since its a bit of a frankenstein but if you check my fork i think it's the most recent minus some of the test commits + some of my own changes for personal binding. apologies if it looks funky I'm not great at git

myrrc commented 3 weeks ago

Seems to be fixed in recent release, feel free to reopen if found again