gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
204 stars 25 forks source link

All n-level submenus share a single shortcut enumeration #198

Closed mfaizsyahmi closed 1 year ago

mfaizsyahmi commented 1 year ago

Suppose I have this menu layout:

The logical thing is to have the subitem and sub-sub-item counter reset on each new parent. In the example above the third level enumeration for A2 starts at i, then ii, etc.

But the extension currently uses a single enumeration for every level, that crosses the parent items such that the orders are as follows:

The ordering (for the purpose of the numbered shortcuts) should have been like in the first example. Having the ordering as it is in the second example means numbered shortcuts breaks if you have more than 10 items across any menu level, because you have &11, &12, &13, etc. all having the same shortcut character (number 1).

I'm not filing this issue under [Feature Request] as I consider the current behavior a bug, one that people have learned to live with. It would break muscle memory if this get fixed but it'd be way more functional.

gyng commented 1 year ago

Released in v3.7.0. Please re-open if the issue is still not fixed. Extension storefronts might take some time to update.

Thanks for your contribution!