h2oai / h2o-3

H2O is an Open Source, Distributed, Fast & Scalable Machine Learning Platform: Deep Learning, Gradient Boosting (GBM) & XGBoost, Random Forest, Generalized Linear Modeling (GLM with Elastic Net), K-Means, PCA, Generalized Additive Models (GAM), RuleFit, Support Vector Machine (SVM), Stacked Ensembles, Automatic Machine Learning (AutoML), etc.
http://h2o.ai
Apache License 2.0
6.88k stars 1.99k forks source link

[GH-16351] Do not call System.exit from water.tools #16366

Open krasinski opened 1 month ago

krasinski commented 1 month ago

fix #16351

wendycwong commented 1 month ago

@krasinski

Your fix has stopped h2o-3 cluster from crashing. I ran the following:

curl http://localhost:54321/99/Rapids --data-urlencode 'ast=(run_tool "MojoConvertTool" ["", "", "", ""])'

and got the following result:

image

From talking to @mmalohlava , he does not want to see the whole stack, just the error message which in this case is

"Caused by:java.lang.IllegalArgumentException: Specified MOJO file (/Users/wendycwong/h2o-3) doesn't exist!",

I took a look and think this is the file that passes everything over:

RapidsHandler.java around line 38 where the whole stack errors are passed as well.

image

wendycwong commented 3 weeks ago

I ran your code again today (sept 4, 2024) but still got the following:

image