h2oai / h2ogpt

Private chat with local GPT with document, images, video, etc. 100% private, Apache 2.0. Supports oLLaMa, Mixtral, llama.cpp, and more. Demo: https://gpt.h2o.ai/ https://gpt-docs.h2o.ai/
http://h2o.ai
Apache License 2.0
11.47k stars 1.25k forks source link

Final response improvements #1863

Closed fatihozturkh2o closed 1 month ago

fatihozturkh2o commented 1 month ago

How it looks on main (without final_answer_guidelines)

https://github.com/user-attachments/assets/9402dda7-df4e-44da-b446-3172754b5905

How it looks on this PR (with final_answer_guidelines)

https://github.com/user-attachments/assets/86012a57-c5c6-4a45-97ad-b86170dd7e2b

Personal Tests

Comparing to the PR: https://github.com/h2oai/h2ogpt/pull/1861

fatihozturkh2o commented 1 month ago

RAG question on main branch:

Screenshot 2024-10-01 at 4 30 31 PM

same RAG question on this PR branch:

Screenshot 2024-10-01 at 4 30 42 PM
pseudotensor commented 1 month ago

Yes let's see if we can isolate the "final" block and (without repeating code) use in both system prompt and that final block.

pseudotensor commented 1 month ago

@fatihozturkh2o

Did you plan to still work on this? I think the resulting conclusion about the below is fine.

Yes let's see if we can isolate the "final" block and (without repeating code) use in both system prompt and that final block.