search

h2oai / sparkling-water

Sparkling Water provides H2O functionality inside Spark cluster
https://docs.h2o.ai/sparkling-water/3.3/latest-stable/doc/index.html
Apache License 2.0
961 stars 361 forks source link

setuptools as run-time dependency #5738

Open mpg640 opened 2 months ago

mpg640 commented 2 months ago

setuptools is not declared as a run-time dependency here: https://github.com/h2oai/sparkling-water/blob/1a0a318dce01180a6b5fe208fa85f110341d67a1/py/src/pyproject.toml#L12

Same with the setup.py:

https://github.com/h2oai/sparkling-water/blob/1a0a318dce01180a6b5fe208fa85f110341d67a1/py/src/setup.py#L40

Currently, it is only listed as a build dependency in both. However, the following line is run when sparkling-water is imported in Python

https://github.com/h2oai/sparkling-water/blob/1a0a318dce01180a6b5fe208fa85f110341d67a1/py-scoring/src/ai/h2o/sparkling/Initializer.py#L195

Note: starting in Python 3.12, setuptools does not come with a venv anymore by default