Setup a per PR test run using CI

habitat-sh / habitat-operator

A Kubernetes operator for Habitat services

Apache License 2.0

61 stars 17 forks source link

Setup a per PR test run using CI #324

Open surajssd opened 6 years ago

surajssd commented 6 years ago

RIght now there is no CI that runs with each PR. We should have a setup where each PR triggers a test run.

Proposal:

We can have a single node k8s setup on Semaphore CI, which runs as following:

Option 1: use minikube with vm-driver none.
Option 2: use kubeadm to start the master and then allow it to schedule pods.

krnowak commented 6 years ago

RIght now there is no CI that runs with each PR. We should have a setup where each PR triggers a test run.

We have it, it runs the tests on GKE through circle ci. But this would need contributors to set up their own GKE instance to have their PR tested, which can be a PITA.

So maybe something based on minikube on some other CI (or maybe even the same) wouldn't be a bad idea, especially if that would allow us to run the tests locally.

I haven't had a look at how it is being done currently, though, so I don't know the details.

kosyfrances commented 6 years ago

@surajssd Here is the commit showing the changes we made to migrate the tests from running on Minikube to running successfully on GKE. Notice we had to change the bind-config service type from NodePort to LoadBalancer here.