feat: [+] MatchBuilder column fun & AND/OR aggregate functions

eruizalo commented 1 year ago

Description

AND / OR aggregate functions were added (equivalent to min and max respectively, but seems more clear this way)

WhenBuilder for columns, very similar to WhenBuilder, intended to do a sequence of comparisons with the column itself. It looks like this:

colInt("c1").matches[String]
.caseW(_ > lit(10), "MAX".lit) // using a "compare" function
.caseW(lit(8), "Eight".lit).   // this is direct comparison between both columns (the very same as ==)
.otherwiseNull

Related Issue and dependencies

Resolves N/A
Depends on N/A

How Has This Been Tested?

This pull request contains appropriate tests?:
- YES

github-actions[bot] commented 1 year ago

:octocat: This is an auto-generated comment created by:

Date : 2023-04-20 10:07:36 +0000 (UTC)
Workflow : PR comment
Job name : create_test_summary_report
Run : 4753054228
Commit : e6e110dac8995302336184a1c71ed3fe6426d9ed Apply suggestions from code review

Actor	Triggering actor	Sender
eruizalo	eruizalo	eruizalo
Triggered by: - Workflow name: "CI" at .github/workflows/ci.yml - URL: [https://github.com/hablapps/doric/actions/runs/4752994384](https://github.com/hablapps/doric/actions/runs/4752994384) - on workflow_run:completed

Test summary report 📊

Spark version	testing
2.4.1
2.4.2
2.4.3
2.4.4
2.4.5
2.4.6
2.4.7
2.4
3.0.0
3.0.1
3.0.2
3.0
3.1.0
3.1.1
3.1.2
3.1
3.2.0
3.2.1
3.2.2
3.2
3.3.0
3.3.1
3.3

codecov[bot] commented 1 year ago

Codecov Report

Merging #336 (36d798c) into main (704185c) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 36d798c differs from pull request most recent head e6e110d. Consider uploading reports for the commit e6e110d to get more accurate results

Additional details and impacted files

[![Impacted file tree graph](https://codecov.io/gh/hablapps/doric/pull/336/graphs/tree.svg?width=650&height=150&src=pr&token=N7ZXUXZX1I&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps)](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) ```diff @@ Coverage Diff @@ ## main #336 +/- ## ========================================== + Coverage 97.49% 97.51% +0.02% ========================================== Files 61 61 Lines 1194 1203 +9 Branches 15 20 +5 ========================================== + Hits 1164 1173 +9 Misses 30 30 ``` | Flag | Coverage Δ | | |---|---|---| | spark-2.4.x | `94.47% <100.00%> (+0.05%)` | :arrow_up: | | spark-3.0.x | `96.60% <100.00%> (+0.03%)` | :arrow_up: | | spark-3.1.x | `97.38% <100.00%> (+0.02%)` | :arrow_up: | | spark-3.2.x | `97.61% <100.00%> (+0.02%)` | :arrow_up: | | spark-3.3.x | `97.61% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) | Coverage Δ | | |---|---|---| | [...c/main/scala/doric/syntax/AggregationColumns.scala](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9kb3JpYy9zeW50YXgvQWdncmVnYXRpb25Db2x1bW5zLnNjYWxh) | `100.00% <100.00%> (ø)` | | | [...rc/main/scala/doric/syntax/ControlStructures.scala](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9kb3JpYy9zeW50YXgvQ29udHJvbFN0cnVjdHVyZXMuc2NhbGE=) | `100.00% <100.00%> (ø)` | | | [core/src/main/scala/doric/syntax/WhenBuilder.scala](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9kb3JpYy9zeW50YXgvV2hlbkJ1aWxkZXIuc2NhbGE=) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps). Last update [704185c...e6e110d](https://codecov.io/gh/hablapps/doric/pull/336?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps).

hablapps / doric