hablapps / doric

Type safety for spark columns
https://www.hablapps.com/doric/
Apache License 2.0
77 stars 11 forks source link

Delete spark 2.4.x version #379

Closed alfonsorr closed 1 year ago

alfonsorr commented 1 year ago

Spark 2.4 is based on Scala 2.11, and is not as used as it was a year ago. Some of the plugins we use are in old versions due to lack of updated versions for 2.11.

Description

Deleted all references to spark 2.4.x

Related Issue and dependencies

241 scala steward will be able to update scoverage plugin again

How Has This Been Tested?

All test should pass

github-actions[bot] commented 1 year ago

:octocat: This is an auto-generated comment created by:

Co-authored-by: Eduardo Ruiz Alonso edu.r26@gmail.com

Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by: - Workflow name: "CI" at .github/workflows/ci.yml - URL: [https://github.com/hablapps/doric/actions/runs/5811916534](https://github.com/hablapps/doric/actions/runs/5811916534) - on workflow_run:completed

Test summary report 📊

Spark version testing
3.0.0 684 passed, 2 skipped
3.0.1 684 passed, 2 skipped
3.0.2 684 passed, 2 skipped
3.0 684 passed, 2 skipped
3.1.0 712 passed, 2 skipped
3.1.1 712 passed, 2 skipped
3.1.2 712 passed, 2 skipped
3.1 712 passed, 2 skipped
3.2.0 716 passed, 2 skipped
3.2.1 716 passed, 2 skipped
3.2.2 716 passed, 2 skipped
3.2 716 passed, 2 skipped
3.3.0 716 passed, 2 skipped
3.3.1 716 passed, 2 skipped
3.3 716 passed, 2 skipped
3.4 716 passed, 2 skipped
codecov[bot] commented 1 year ago

Codecov Report

Merging #379 (2f32afe) into main (d4e684c) will increase coverage by 0.08%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/hablapps/doric/pull/379/graphs/tree.svg?width=650&height=150&src=pr&token=N7ZXUXZX1I&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps)](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) ```diff @@ Coverage Diff @@ ## main #379 +/- ## ========================================== + Coverage 97.61% 97.69% +0.08% ========================================== Files 62 62 Lines 1256 1255 -1 Branches 17 37 +20 ========================================== Hits 1226 1226 + Misses 30 29 -1 ``` | Flag | Coverage Δ | | |---|---|---| | spark-2.4.x | `?` | | | spark-3.0.x | `96.71% <ø> (-0.04%)` | :arrow_down: | | spark-3.1.x | `97.45% <ø> (-0.05%)` | :arrow_down: | | spark-3.2.x | `97.66% <ø> (-0.05%)` | :arrow_down: | | spark-3.3.x | `97.66% <ø> (-0.05%)` | :arrow_down: | | spark-3.4.x | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) | Coverage Δ | | |---|---|---| | [....0\_3.1/scala/doric/syntax/BinaryColumns30\_31.scala](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#diff-Y29yZS9zcmMvbWFpbi9zcGFya18zLjBfMy4xL3NjYWxhL2RvcmljL3N5bnRheC9CaW5hcnlDb2x1bW5zMzBfMzEuc2NhbGE=) | `100.00% <ø> (ø)` | | | [....0\_3.1/scala/doric/syntax/NumericColumns2\_31.scala](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps#diff-Y29yZS9zcmMvbWFpbi9zcGFya18zLjBfMy4xL3NjYWxhL2RvcmljL3N5bnRheC9OdW1lcmljQ29sdW1uczJfMzEuc2NhbGE=) | `100.00% <ø> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/hablapps/doric/pull/379/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps). Last update [d4e684c...2f32afe](https://app.codecov.io/gh/hablapps/doric/pull/379?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hablapps).
eruizalo commented 1 year ago

you should update the doc as well