hackclub / high-seas

🏴‍☠️ It's better to be a pirate than join the navy!
https://highseas.hackclub.com
72 stars 21 forks source link

Tutorial breaks if user closes verification or sticker ordering before completion #790

Open polytroper opened 1 week ago

polytroper commented 1 week ago

Right now if the user closes the verification or sticker order form without completing them, the tutorial will break. If they reopen the magic link from slack, they get stuck in a loop on the ts-signpost step. If they navigate to any other page, it just takes them back to the signpost and shows the final tutorial step. I just got an email from a user in this situation and tested it myself. Instead of setting the next tutorial step on button click, I think we need to set that step when the user navigates to the page and the person record has academy_completed == true

Make sure to independently test the cases where the user closes during verification and when they close during the order flow step (not just the address, but the actual order flow!) because these are subtly different. Also we need to test the case where they close on one browser and reopen on another, which currently sends them back to the start of the tutorial. This is correct but we should make sure it stays working.

zeankundev commented 3 days ago

Same issue here