hackerdeen / hackhub

Membership system
4 stars 2 forks source link

Cleanup #20

Open AndyGaskell opened 3 months ago

AndyGaskell commented 3 months ago

From Rob...

Hub has a few features that connect to other things that don't exist anymore. Could do with cleaning that up (at least removing UI for it or putting it behind a feature flag). Or do something to bring back the other stuff it relies on if anyone cares to have these features again. Things I think could do with being cleaned up:

  • generate an open/close message for space status (the other system that generated these was on one of my servers that I killed (a few years ago)- I probably still have the code and could put it somewhere again if anyone cared about this).
  • text message codes to unlock the door. I stopped paying twillio (if I'm remembering the correct company name there) for the number that was receiving these messages. I think I killed the UI for this but there is still the API stuff to receive codes that can probably go: https://github.com/hackerdeen/hackhub/blob/master/api_sms.py
  • We have a thing³ that gives list of member emails that used to feed into something to create @57north aliases. I don't think downstream bits of that are still running so would be good to kill the API end point and not have risk of secret for accessing it being guessed/leaked and this being accessible to anyone that it shouldn't be.

³ https://github.com/hackerdeen/hackhub/blob/master/api_membership.py#L48

...via https://lists.57north.org.uk/mailman3/hyperkitty/list/57north-discuss@lists.57north.org.uk/thread/4WCY7N4D7UV7HMN4ZOFEDX45JWLFPLQ5/

AndyGaskell commented 3 months ago

See also...