Open roslynwythe opened 1 year ago
Hi @roslynwythe.
Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Complexity, Role, Feature
NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.
To add a label, take a look at Github's documentation here.
Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.
After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.
Additional Resources:
@roslynwythe I moved this into the new issue review column because the dependency is resolved. Please add a ready for prioritization label if its ready.
Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
Hi @Jung-GunSong, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
i. I'm available throughout this and next week.
ii. By end of next week.
@Jung-GunSong I have moved this issue to the in progress column. Next time you self assign, please remember to move the issue. 👍
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Monday, February 19, 2024 at 11:06 PM PST.
Here my update:
I apologize for the lack of progress on this issue so far. Im the process of moving, and it made me busier than I thought. I will be able to give this my full attention next week.
I am also willing to unassign myself to this issue, someone wants to jump into this issue right now.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Monday, March 4, 2024 at 11:06 PM PST.
Here is another update:
Hi @Jung-GunSong were you able to get your test environment setup? If not, we could check your file permissions on Google Drive and re-share the documents. If you are making progress on this issue, please move it to "In Progress".
Hi @roslynwythe I haven't been able to yet. I was thinking of popping into office hours today to get it resolved.
@Jung-GunSong were you able to drop in on office hours?
@ExperimentsInHonesty Hi Bonnie, I did drop in and I was asked to DM Roslyn about my blocker. We have been in communication and are working on it.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, April 23, 2024 at 12:06 AM PST.
Hi @Jung-GunSong! Thanks for working on this issue. If you're still working, please add an update. If you're not able to continue to working on it, leave us a comment to let us know. If we don't hear from you soon, we will remove you from the issue. Thanks!
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, April 30, 2024 at 12:06 AM PST.
Hi @Jung-GunSong let me know if you are still able to work on this issue.
As I mentioned, I think the problem most likely has to do with your token. It is easy to have a mixup with the files containing the key, so I wanted to check, have you modified setToken so that it references the actual name of the file containing the key, like this: function setToken_() { let id; const files = DriveApp.getFilesByName('testgh-key-justin') while (files.hasNext()) { const file = files.next(); if (file.getName() === 'testgh-key-justin'){ id = file.getId(); } } because if you have not changed the file name appropriately, you may be retrieving the wrong token.
Also, it would be helpful for me to have your unencoded token. You can use a statement like:
console.log(documentProperties.getProperty(TOKEN
))
to print that out.
If you would like, we could schedule a meeting by zoom to work on this together.
@LRenDO Hi Ren, sorry that I've been off the radar lately. I have will have more time to work on this issue in the next week or two. Sadly I have been stuck on getting the environment set-up. If my progress has been too slow, I can hop off the ticket to let someone else have a try at it.
@roslynwythe Thank you for following up. I won't be able to look into this more seriously until next week. If that is too much time to wait, I can hop off to give someone else a try. Before the next week I will look into the token, and see if this would be an issue that needs to be fixed via zoom.
ok thanks @Jung-GunSong
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, May 21, 2024 at 12:06 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, May 28, 2024 at 12:06 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, June 4, 2024 at 12:06 AM PST.
@Jung-GunSong I am moving this issue to the questions column, and adding the label ready for dev lead
@Jung-GunSong For my testing, I had to change the name from gh-key
to something else, because the code was finding another file with the name gh-key
in my shared folders. So I would suggest that you change the name as well. By the way, I deleted your message because I don't want to expose your token. If that doesn't work then yes I think we should arrange to meet.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, July 30, 2024 at 12:05 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, August 6, 2024 at 12:04 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, August 13, 2024 at 12:14 PM PST.
@Jung-GunSong please leave an update using the template above.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, August 27, 2024 at 12:04 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, September 3, 2024 at 12:04 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, September 10, 2024 at 12:04 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, September 17, 2024 at 12:04 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, October 1, 2024 at 12:04 AM PST.
@Jung-GunSong
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, October 8, 2024 at 12:05 AM PST.
@roslynwythe please update the top of this issue with anything you think is relevant from your comment threads above, so that we can hide them and reprioritize this issue.
Hi @roslynwythe, we notice that you are assigned to an issue that you authored. Please remember to add the Draft
label to this issue while you are working on it.
Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
@roslynwythe there are still unresolved comments in this issue. Please review and hide
Dependency
Overview
We need to create new fields to hold only GitHub and LinkedIn handles (in contrast to the current fields which contain complete URLs), and to incorporate those fields into the Response sheet, Review sheet, and the _wins-data.json feed.
Details
We set up validation on the wins form so that users could give us the handles, with and without URL prefixes, now we need to take only the handle into the relevant sheets, so that we can (in another issue) update the .js files.
Ultimately, the goal is to have the URLs on the wins page (you can see them when you hover over the LinkedIn and GitHub icons), have a standard format. See epic for more details.
Action Items
wins-form-responses
within the Wins-form (responses)^2 sheet, but you will require a Google Drive test environment that includes copies of Wins-form (Responses)^2, gh-requests^3, and Wins-form[^6]. It will also be useful to read Wins Form Admin Guide[^1]. It will also be necessary to setup a test environment in your GitHub repository. Follow instructions in the comment in the Hfla Google Apps Script Development Process Guide[^4] and Testing WINS in a test repository[^5]Wins-form
, including the issue # in the name, then share that copy with the developer as EDITOR.Responses
settings of theWins-form
so that test submissions will be stored in the Wins-form (Responses} that is in the test environmentinsertLatestFormSubmitIntoReviewSheet
andcreateIssue
functions will execute when a form is submittedmain()
for testing, you must follow instructions in Testing WINS in a test repositoryclasp
utility can be used to transfer code back and forth between the local worksation and the Google Drive as needed.Response
sheet, create two new columnsGitHub-handle
andLinkedIn-name
insertLatestFormSubmitIntoReviewSheet
populate the new columns with strings extracted from the submitted data in theGitHub URL
andLinkedIn URL
columns in theResponse
sheet.GitHub-handle
andLinkedIn-name
, along with the submitted data forGitHub URL
andLinkedIn URL
, on the Review sheet.main
add code to include theGitHub-handle
andLinkedIn-name
fields in _wins-data.jsonCode.js
and creating a pull request.Resources/Instructions