Open 8alpreet opened 3 months ago
Hi @8alpreet, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
How many hours did it take you to finish this step?
A: ~30
Which meetings did you register for:
When did you attend your first team meeting? A: Aug 8, 2024
How many hours did it take you to finish this step?
A: ~30 min
How many hours did it take you to finish this step? A: 5 min
How many hours did it take you to finish this step? A: ~25m
Do you have any questions about what you read?
Hi @8alpreet I wanted to let you know that I have fixed the links to the Project Board in Contributing.md - Hack for LA Section 2.3
Hi @8alpreet I wanted to let you know that I have fixed the links to the Project Board in Contributing.md - Hack for LA Section 2.3
Awesome, thank you!
What is the number of your first merged pull request?
Did you receive any reviews that required you to change anything on your PR?
Comments: I learned that the purpose of the "Why did you make the changes (we will use this info to test)?" question is to provide a quick summary/insight into the changes without having to open the issue. My initial comment was ~ "because the issue said to make these changes" which made sense, but after the feedback I see it makes more sense to give a quick summary/snippet of the reasoning.
What is the number of your 2nd merged pull request?
Did you receive any reviews that required you to change anything on your PR?
I have reviewed a good first issue
PR #7293
Did you catch anything?
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
I have reviewed a good first issue
PR #7306
Did you catch anything?
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
I have reviewed a good first issue
PR #7346
Did you catch anything?
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
maybe replace
9 - PULL REQUEST REVIEWS - GFI - Update
I have reviewed a
good first issue
PR #7315
Did you catch anything?
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
I have reviewed a good first issue
PR #7320
Did you catch anything?
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
Up to now we have just been getting you ready. Now the fun starts. Are you continuing?
Comments:
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, August 27, 2024 at 12:04 AM PST.
What is the number of your small merged pull request?
Did you receive any reviews that required you to change anything on your PR?
Comments:
There are currently no small
PRs to review, but i'll check back later.
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, September 10, 2024 at 12:04 AM PST.
Which EPIC or ER did you work on (provide the issue number)
How many hours did it take you to make the issue(s)?
Did you find anything required clarification or anything we could improve about the instructions?
Suggestions for improvement:
I have reviewed a small
PR #7447
Did you catch anything?
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
if yes, describe what you learned: A:
I have reviewed a small
PR #7462
if yes, describe what you learned: A:
I have reviewed a small
PR #7466
if yes, describe what you learned: A:
There are no medium issues right now. Please let me know if one becomes available.
The link to issue making level 1 in Section 14.1 has an invalid filter query. The current link uses status "ERs and epics that are ready to be turned into issues" which seems to be a comment under the status not the status itself. The valid status is "Make Issues: ERs and epics".
What is the number of your medium merged pull request?
Did you receive any reviews that required you to change anything on your PR?
Comments:
I have reviewed a medium
PR #7501
Did you catch anything?
[x] yes
[ ] no
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
[x] no
[ ] yes
if yes, describe what you learned:
A:
I have reviewed a medium
PR #7569
Did you catch anything?
[x] yes
[ ] no
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
[x] no
[ ] yes
if yes, describe what you learned:
A: While I did catch something, I still learned from others. I learned that I could have shared the error that presents in docker and dev tools. From my diagnosis, I thought the error was misleading, but it would've been helpful to include it anyways. Also, I could've have informed the person add the "help wanted" label or "questions/ In Review" status.
@8alpreet on your last comment, you said that you learned something from your PR review. But you didn't say what you learned. Please edit.
@8alpreet You don't need to do section 14.1 because it says "Only work on this section if you needed a medium issue and one is not available from the prioritized backlog" Since you already did a medium size issue, you should move on to section 15. Which it looks like you have done. I am going to remove the needs issue: medium
label from your issue.
Here is another Medium size PR to review. You will not need to review any other medium, small, or good first issue PRs after you do this one medium pr review. Please see the above issue details for maximum number you should review. https://github.com/hackforla/website/pulls?q=is%3Aopen+is%3Apr+label%3A%22Complexity%3A+Medium%22+review%3Arequired
After you review this pr, go onto section 16.
@8alpreet on your last comment, you said that you learned something from your PR review. But you didn't say what you learned. Please edit.
Hi @ExperimentsInHonesty, thanks for looking at my issue. I believe you'r talking about my review for PR 7501. It is my understanding that I'm supposed to describe what I learned if I didn't catch anything but someone else did. Am I supposed to describe what I learned from what I caught?
I have reviewed a medium
PR #7589
Did you catch anything?
[x] yes
[ ] no
If you did't catch anything, did anyone else who reviewed it after you, catch anything?
[x] no
[ ] yes
if yes, describe what you learned:
A:
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, October 22, 2024 at 12:04 AM PST.
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Tuesday, October 29, 2024 at 12:04 AM PST.
On step 16, waiting for my issues to be accepted.
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Monday, November 11, 2024 at 11:04 PM PST.
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Monday, November 18, 2024 at 11:04 PM PST.
@8alpreet
Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the Questions/In Review
column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.
You are receiving this comment because your last comment was before Monday, November 25, 2024 at 11:04 PM PST.
Prerequisite
We are looking forward to having you on our team. Please make sure to attend the general Hack for LA onboarding to get the process started https://meetup.com/hackforla/events.
Overview
As a developer on the website team this issue will be your companion and a place to track your progress with the path we have set out for you.
Special Notes
Action Items
Table of Contents
Sections 1 - Joining the website team 2 - Team Meetings (Options and Requirements) 3 - Development Environment Setup 4 - First GitHub Issue (GFI) 5 - Weekly Updates 6 - 1st Pull Request 7 - Additional reading 1 8 - 2nd good first issue 9 - Pull Request Reviews - GFI 10 - Additional reading 2 11 - Small Issue 12 - Pull Request Reviews - Small 13 - Issue Making - Level 1 (GFI & Small) 14 - Medium Issue 14.1 Issue Making - Level 2 (Medium) 15 - Pull Request Reviews - Medium 16 - Issue Making - Level 2 (GFI) 17 - Merge Team Skills Review FAQ Resources
1 - JOINING THE WEBSITE TEAM.
[x] Self Assign this issue (gear in right side panel).
[ ] If there are no gears in the right side panel of this issue (next to Assignees, Labels, Projects, Milestone, Development):
[ ] check to see if you are logged in to GitHub (if you are not logged in you will see a sign in button on the top right of this browser tab).
[ ] add the following text to a comment on this issue
role: front end
orrole: back end/devOps
or both label(s) to this issue and remove therole missing
label (gear in right side panel)[x] Post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
2 - TEAM MEETINGS (OPTIONS AND REQUIREMENTS)
[x] Post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
3 - DEVELOPMENT ENVIRONMENT SETUP
[x] Post the following message in a comment below on this issue and then answer it. While keeping in mind that this is just to get feedback on how long it took you to get to this point. There is no right or wrong answers. There is no judgement. It is ok if you take a long time or if you do it really fast or at any pace. Getting your dev environment setup will be easier for some people because they might already have some experience or items installed on their computer and you may not. This is an important step, be patient with yourself and your computer but keep on it till you get it done.
⇧ Table of Contents
4 - FINDING AND ASSIGNING YOUR FIRST GITHUB ISSUE (GFI)
Once you self assign an issue, an automation will post a welcome message in a comment giving you additional guidance to manage your issue (includes how to provide estimates and progress reports there).
[x] On assignment, you will be prompted to estimate Availability and ETA.
Once you have done that on your good first issue, check this box, above, on this issue to let us know you have completed that task and understand how to do it in future.
ready for dev lead
andStatus: Help Wanted
[x] Post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
5 - GIVING WEEKLY UPDATES ON YOUR DEVELOPMENT ISSUES
[ ] Post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
6 - SUBMITTING YOUR FIRST PULL REQUEST
[x] Once your pull request has been accepted, post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
7 - ADVANCED READING TO READY YOU FOR LARGER MORE COMPLEX ISSUES
[x] Post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
8 - MOVE ON TO 2ND GOOD FIRST ISSUE (AKA, IT GETS EASIER AND DID YOU BRANCH CORRECTLY?)
Once your pull request has been accepted
[x] post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
9 - GOOD FIRST ISSUE (GFI) PULL REQUEST REVIEWS
Now that you have two merged
good first issue
PRs, you are eligible to review good first issue PRs, Review Required from other people who are following in the same journey path as you.See How to review Pull Requests guide will teach you how to review pull requests.
Please review 5
good first issue
PRs. Each PR requires at least two reviews, so by reviewing 5 good first issue PRs you are repaying the effort that others did for you (provided 4 reviews for your 2 good first issues) plus 1 extra review to help us all make up the deficit for people who submit a PR but don't get this far.good first issue
prgood first issue
prgood first issue
prgood first issue
pr[x] reviewed 5th
good first issue
pr[x] After each
good first issue
PR that your review, please paste the following text in a comment below[ ] If there are no
good first issue
PRs to review right now, paste this comment instead and check back later. You can also go onto section 10.⇧ Table of Contents
10 - UNDERSTAND HOW TO PROGRESS THROUGH ISSUES IN THE PRIORITIZED BACKLOG AND ON ISSUE MAKING AND TEMPERATURE CHECK
Congrats on making it this far. Issues get more complicated from here, either they include more changes, or have several files to change or you have to research something that we are unsure how to do, or there is complicated logic that needs writing or rewriting. Each issue size that you take on will guide you to a more complicated level in sequence, and you can see from the labels and overviews what they are about.
Its important that you try to work on issues that fill in gaps in your knowledge (see the self tests for a reminder about what to look for).
So keep going, the fun stuff is about to start.
Having said that, we are also going to have you take on some issue making (surprise! There is no issue making fairy, only volunteers like you that created issues for the people that come after them). Pay attention to how the issues you have already worked on are constructed and how they change as they go up the ladder. That way when we start you on the issue making portion of the team work, you will know what you are shooting for when its your time to make issues.
Also, we want you on the Merge team. This will ensure you are a competent developer and an awesome collaborative contributor to any team you join in the future.
[x] Let us know that you have re-reviewed your issues, have read the above and are continuing on the team
[THIS WHOLE THING COULD BE MOVED TO A WIKI PAGE THAT EXPLAINS THE VALUE TO THEIR CAREER AND HAVE A TLDR HERE]
⇧ Table of Contents
11 - MOVING ON TO A SMALL ISSUE
[x] Once your pull request has been merged post the following message in a comment below on this issue and then answer it:
⇧ Table of Contents
12 - PULL REQUEST REVIEWS - SMALL
Now that you have your small PR merged, you are eligible to review small PRs, Review Required from other people who are following in the same journey path as you.
Please review 3
small
PRs. Each PR requires at least two reviews, so by reviewing 3 small PRs you are repaying the effort that others did for you (provided 2 reviews for your 1 small issue PR) plus 1 extra review to help us all make up the deficit for people who submit small PRs and then drop off the team.small
prsmall
pr[x] reviewed 3rd
small
pr[x] When you have reviewed a
small
PR, please paste the following text in a comment below[ ] If there are no
small
PRs to review right now, paste this comment instead and check back later. You can also go onto section 13.⇧ Table of Contents
13 - GET EXPERIENCE MAKING ISSUES - LEVEL 1 (GFI & Small)
Creating issues from templates will give you experience on how issues
and like the good first and small issues you have already done, they are perscritive enough to do with no prior experience issue making.
ready for merge team
Once the ER or Epic has been accepted by the Merge team and closed and the issue(s) you created have been moved into the prioritized backlog
[x] Post the following message in a comment below on this issue and then answer it.
⇧ Table of Contents
14 - MOVING ON TO A MEDIUM ISSUE
[x] Take the first issue from this prefiltered view of the project board (status: prioritized backlog, medium issues = dev: medium)
[x] If there is medium size issue in the prioritized backlog column
[x] Once your pull request has been merged, post the following message in a comment below on this issue and then answer it
⇧ Table of Contents
14.1 MAKE A MEDIUM ISSUE FROM AN ER OR EPIC
Only work on this section if you needed a medium issue and one is not available from the prioritized backlog
needs issue: medium
to this issue, so that we can notify you when new medium size issues are released[x] add the following comment to this issue
ready for merge team
ready for merge team
ready for prioritization
label is added. When the new issue(s) are approved, the issue making issue will be closed and you are welcome to move onto the next checkboxneeds issue: medium
⇧ Table of Contents
15 - PULL REQUEST REVIEWS - Medium
Now that you have your medium PR merged, you are eligible to review medium PRs, Review Required from other people who are following in the same journey path as you.
Please review 3
medium
PRs. Each PR requires at least two reviews, so by reviewing 3 medium PRs you are repaying the effort that others did for you (provided 2 reviews for your 1 medium issue PR) plus 1 extra review to help us all make up the deficit for people who submit medium PRs and then drop off the team.medium
prmedium
pr[x] reviewed 3rd
medium
pr[ ] When you have reviewed a
medium
PR, please paste the following text in a comment below[ ] If there are no
medium
PRs to review right now, paste this comment instead and check back later. You can also go onto section 16.⇧ Table of Contents
16 - ISSUE MAKING - LEVEL 2, GFI
ready for merge team
ready for merge team
⇧ Table of Contents
17 - MERGE TEAM SKILLS REVIEW
We want everyone who joins this team to get onto the merge team so that you can get experience running meetings and office hours, mentoring, creating sufficent workflow for the team, escalations, and ultimately being responsible for final approval and merging of pull requests made by team members on lower sections. At this point we will check to see if you are ready to join the merge team, or what your next steps are to get you closer to ready.
[ ] When you get to this point, please paste the following message into a comment below
⇧ Table of Contents
FAQ section
Are there exceptions to which size issues I work on?
- Medium (you can work on one medium issue, but only one at a timeone per person, with some exceptions, see below) - Large (you can work on more than one large issue, but only one at a time) - The reasons for this progression are: - The issues start out as being prescriptive and become less so as you gain more experience by working through increasingly complex issues. - We are trying to teach you the team methodology through the issues themselves. - It ensures you understand what we expect and the quality of contributions. - You can work on back-to-back small issues if it meets the following criteria: - You are learning something new and need to work on an issue of a lesser complexity - Since we have a limited number of these, you must get approval from lead or pm - You can work on a second medium issue if it meets the following criteria: - You are learning something new and need to work on an issue of a lesser complexity - Since we have a limited number of these, you must get approval from lead or pmWhat should I do if I have a question about an issue I'm working on, and I haven't gotten a response yet?
- First, you should post the question or blocker as a comment on your assigned issue, so it can be easily referred to in the next bullet points. - Then, add the label `Status: Help Wanted` so other developers can see it and potentially help answer your question. In addition, you will still need to post a Slack message or bring it up in meeting so we know you need help; see below for how to do that. - Also, you can post your question on the hfla-site Slack channel and link the issue you're working on, so other developers can see and respond. - Lastly, you can add the issue to the"Development team meeting discussion items""Questions/In Review" column of the Project Board so that it can be addressed in the next development meeting. Please bring it during the meeting that you need help.If you need to take some time off from the team
Copy and customize this response, and leave it in a comment on this issue ``` I need to take some time off from the team. I believe I will be back on [Replace with DATE YOU WILL BE BACK] ``` - If you have put work in, please make sure its well documented. - Add the label `away on hold` - Move this issue to the questions column - if you are assigned to an issue, if you have not yet made any progress on the issue, please unassign.⇧ Table of Contents
Resources/Instructions
⇧ Table of Contents
Skills List - INTAKE
Skills List, self test on Intake, fill out when you join the team, don't update
Front End
[x] Pull Requests
Back End
[x] CRUD operations
All Developers
Return to section 1 section 10
Skills List - ONGOING
Skills List, update as you do work on this team
Front End
[x] Pull Requests (section 8)
Back End
[ ] CRUD operations
All Developers
⇧ Table of Contents