Feature/finish task modal

hackoregon / civic

The frontend monorepo for the CIVIC platform.

http://civicplatform.org

MIT License

60 stars 26 forks source link

Feature/finish task modal #1169

Closed ghost closed 4 years ago

ghost commented 4 years ago

Adds the new designs requested by OMSI for V5.

replaces the taskMap with simple choose task UI
adds modals: help others intro, chosen task description, successful task completion, unsuccessful task timeout
a very large refactor that centralizes most of the phase controlling into the tasks redux state that had previously been in the tasks/index.js and tasks/taskscreen.js. The latter no longer needs to exist.

jaronheard commented 4 years ago

I've done some play through testing. Things seems to be working for me.

A couple of comments: • Modal dialog timing seems too long in comparison to gameplay time • If you select tasks where you don't have the correct item in your kit, the "Keep Playing" modal will pop up. • Font spacing on "You Saved" and "Badges Earned" in title bar is off

When the thunderstorm is displayed, it says "It's cold out here", but blankets aren't useful, which is confusing. Should say something like "It's wet out here".

ghost commented 4 years ago

Responding to your comments:

For the modal timing: I got comments from them before that they wanted them to be 2x as long… I think I should leave them as is and then if they think they’re too long they’re easy enough to shorten up but I agree they are rather long
Keep Playing modal popping up during a task player doesn't have the item for. Right now this popup is set up to go off on a timer, I could make the timer restart when this case comes up if that sounds good?
Font spacing looks correct on the big screen, but never on smaller screens set to the same resolution for some reason. In any case, the titlebar will be redone in one of the next two releases

jaronheard commented 4 years ago

Sounds good!

Keep Playing modal popping up during a task player doesn't have the item for. Right now this popup is set up to go off on a timer, I could make the timer restart when this case comes up if that sounds good?

Maybe it should just be longer rather than resetting? If it resets and you didn't add anything relevant to your kit then would the game keep playing itself for too long? Happy with what you think is best.

ghost commented 4 years ago

Woops! I made it 10s while developing. It's now set to 35s. Good catch!