hackoregon / civic

The frontend monorepo for the CIVIC platform.
http://civicplatform.org
MIT License
60 stars 26 forks source link

Common module build script and tooling clean-up #1208

Closed jaronheard closed 4 years ago

jaronheard commented 4 years ago

What

For the new packages added in #1200:

See https://github.com/hackoregon/civic/pull/1200#pullrequestreview-422433476 for additional detail

Why

Follow up from #1200

jaronheard commented 4 years ago

Note: The common scripts and tooling are working fine for now. In #1214, I added a watch script for the new component packages, so that you can rebuild components across packages. At some point, we could pull up some scripts to a common scripts directory, but I think it's fine for now.

When investigating bundling packages more compactly, I was getting better results with our current build system that just uses Babel, then I was with the Rollup configuration I started testing in. With our current build system, code-shaking is working well in basic configurations like Gatsby and create-react-app. I fixed an issue with code-shaking for ui-core in #1210