Design System - Update Icon Map Stories

[paigewilliams]

What

What needs to be done?

Standard

• [x] Rename"Simple Usage" story to "Standard" story

• [ ] Create knobs for each of these standard props and group as marker: -getIcon -getSize -iconAtlas -iconMapping -iconSizeScale -getColor -opacity

• [ ] Create knobs for each of these standard props and group as data: -data -getPosition

Custom

• [ ] Create "Custom" story
• [ ] Create knobs for each of these custom props and group as custom: -autoHightlight -highlightColor -onLayerClick

Example

• [x] Rename "With tooltip" story to "Examples: With Tooltip" story
• [x] Rename "TouchScreenDemo" story to "Examples: Touch Screen" story

Notes

• [ ] Add IconLayer Map Notes file

Why

Why does it need to be done? (Include links to related issues) IconLayer Map stories should follow the Civic design system pattern established in #508, #553, and #565. Please references these files:

Button Component -Button Stories File -Button Notes File

Bar Chart Component -Bar Chart stories -Bar Chart notes

Horizontal Bar Chart Component -Horizontal Bar Chart stories -Horizontal Bar Chart notes

When

When does this need to be done? In the near future

[mendozaline]

@jaronheard should the TouchScreenDemo story be removed or should it be kept and be made an example story?

[jaronheard]

I think we should keep it as an example. Should be useful as we work on the OMSI project

On Fri, May 24, 2019 at 2:39 PM David Mendoza notifications@github.com wrote:

@jaronheard https://github.com/jaronheard should the TouchScreenDemo story be removed or should it be kept and be made an example story?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hackoregon/civic/issues/569?email_source=notifications&email_token=ABV5AXYYSRB4J5ISSIA4Y4LPXBOBPA5CNFSM4HPSNJJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGTZAY#issuecomment-495795331, or mute the thread https://github.com/notifications/unsubscribe-auth/ABV5AXYTL5MSXYYVMI5GPO3PXBOBPANCNFSM4HPSNJJQ .

--

Jaron Heard Creative Director Civic Software Foundation +1-971-998-7180

[corydm92]

I believe getPosition has a default of d => d.geometry.coordinates that should be moved to custom instead of the standard usage story.

[paigewilliams]

@corydm92 Thanks for pointing that out! I have removed the getPosition knob in the ScatterPlot Map and Path Map, so it can be ignored in this issue.

[jaronheard]

Note, recommend holding off on writing the stories for IconMap because the component is (potentially) being redesigned.