search

hadley / ggplot2-book

ggplot2: elegant graphics for data analysis
https://ggplot2-book.org/
1.57k stars 683 forks source link

Reciprocal vs reverse #293

Closed kent37 closed 1 year ago

kent37 commented 2 years ago

This statement is incorrect: https://github.com/hadley/ggplot2-book/blob/763f146a3bf59515d66aec8f63dcd964b42a3a40/scales-position.Rmd#L274

The plot in the previous example uses scale_y_continuous(trans = "reciprocal") so it does not match scale_y_reverse().

Probably the previous example should use trans="reverse" to match .

djnavarro commented 1 year ago

Looks like this was covered when #260 merged. The current phrasing makes it clearer (I think) that the reciprocal transformation doesn't have a convenience scale function, whereas the reverse transformation does. I'm hoping that in the current form the reader is better able to connect the scale_x_reverse() remark to the example a couple of paragraphs earlier that uses the reverse transformation. I'll concede it's still less than ideal but definitely better than the text looked at the time this was opened! I'll close this now, but may want to revisit when the book gets close completion