search

hagenburger / pimd

PIMD – Processing Instructions for Markdown
https://hagenburger.github.io/pimd-docs/
MIT License
20 stars 5 forks source link

Implement Prism plugin #67

Closed hagenburger closed 5 years ago

hagenburger commented 5 years ago

~~I’m pretty unhappy with the fix needed for Travis CI.~~

Update: I found a better way and opened PR #69.

@benevbright @tobmaster: do you have any idea how to improve/configure this? You can see the error here: https://travis-ci.org/hagenburger/pimd/jobs/433770967

tobmaster commented 5 years ago

@hagenburger hmmm do you really want to test all plugins with the main project? IMHO those should just have their own test suite and been tested individually?

hagenburger commented 5 years ago

@tobmaster how would you set this up?

hagenburger commented 5 years ago

@benevbright I just rebased and included #70.

hagenburger commented 5 years ago

@benevbright it seems not to work with the npm install each install plugin folder :( Should we go back to lerna bootstrap or do you have any idea?

benevbright commented 5 years ago

Hm... can you exclude package-lock.json?

hagenburger commented 5 years ago

How and for which result?

benevbright commented 5 years ago

I mean, can you remove package-lock.json in prism plugin and push again?

hagenburger commented 5 years ago

@benevbright OK … seems to fix it.

hagenburger commented 5 years ago

@benevbright is it approved?