haiku / infrastructure

Haiku infrastructure as code
https://hub.docker.com/r/haiku
MIT License
15 stars 16 forks source link

concourse: re-runs builds each day even when there are no new commits on the git repos. #76

Open OscarL opened 1 year ago

OscarL commented 1 year ago

Not sure if this is the correct place to bring this up. I might be reading things the wrong way... and this is not actually an issue. If that's the case, I apologize in advance.

While nosing around https://ci.haiku-os.org/ and https://cgit.haiku-os.org/haiku/log/, I've noticed that... despite the last commit on the beta3 branch being from 2022-07-12, concourse seems to be creating new builds daily for that branch (both for 64 bits and 32 bits).

I admit that I might reading it wrong, but logs like for build 478 and older ones like build 445, to use any two examples... seem to be rebuilding things for the same git commit reference.

As this seems quite wasteful to my untrained eye... I thought it made sense to report it. Again, if this is just "working as expected"... please disregard my intrusion.

nielx commented 1 year ago

Good spot, we previously reduced it to once a week after a release, I guess we skipped that this time. We are soon going to move to the beta 4 branch, and I suspect we do want daily builds from that, though it would be good if it can be made conditional on new commits in the branch.

OscarL commented 11 months ago

For what it is worth... concourse seems to keep building beta4 once each day, even if when there are no new commits. Well... when it works at least, as the 32 bits builds have been failing for quite a few days already.

Maybe something like this can be used to stop the build if the git hash hasn't changed? (I know I'm not the one paying the bill, but just seems like a waste of electricity :-/)

Tagging @kallisti5, just in case.

leavengood commented 11 months ago

I started also running a builder and I certainly don't want to waste CPU cycles and energy on this so hopefully it can be fixed. Also the 32-bit builds were failing on my builder because of Ubuntu stupidity. Even getting the 64-bit builds working was very painful. I plan to replace Ubuntu with Debian soon, which should work better. I just did not have time to fix it until today. @kallisti5 also got better internet so his builder should also be working somewhat better.