Relax node-sass dependency; supply default CLI-importable file for node-sass.

haithembelhaj / sass-inline-svg

node-sass function that inlines SVG files

22 stars 22 forks source link

Relax node-sass dependency; supply default CLI-importable file for node-sass. #3

Closed seansfkelley closed 7 years ago

seansfkelley commented 7 years ago

This PR has two changes:

Change node-sass to a peer dependency instead of a hard dependency. This means that you'll use whichever version is provided by your build environment instead of bringing in your own. I ran into a problem where I had competing versions of node-sass because I was on 4.x and this function depended on 3.x.
Provide a default.js that node-sass users can use with the CLI if they just want default options (instead of having to switch to specifying the build task with js).

seansfkelley commented 7 years ago

Looks like the build is failing because node-sass itself is failing to install on Travis. Not sure how to resolve that one.

seansfkelley commented 7 years ago

Ping @haithembelhaj, any thoughts on this?

haithembelhaj commented 7 years ago

Hello @seansfkelley, I'm sorry for keeping you waiting. I'm currently on vacancy but I had this pull request on my todo list. First of all great work! I didn't know about the default.js CLI usage. Nice! I tested your pull request and updated the node-sass version. Works good to me! (see https://travis-ci.org/haithembelhaj/sass-inline-svg/builds/262580604). I also prefer 'inline-svg' you could change the docs accordingly and update node-sass in the package.json and I will happily merge your pull request.

Thank you for your contribution!

seansfkelley commented 7 years ago

Awesome, thank you very much!