hajkmap / Hajk

A modern, full-featured OpenLayers based map viewer and editor
MIT License
123 stars 47 forks source link

Search: Overlap fixes #1545

Open OlofSvahnVbg opened 2 months ago

OlofSvahnVbg commented 2 months ago

There is some issue with the overlap of the search window in app:

image

As shown above, the search result window under the search bar is always displayed on top, which is not ideal when working with one or more control windows placed to the right of the screen.

This has been reported by some users as a problem.

The drawerButtons have a similiar problem when overlapping with other windows:

image

Otherwise, the control windows behave correctly when interacting with each other. The active window is put on top when clicked or interacted with, as it should.

I think this should be fixed by changing logic for search and drawerbuttons.

jacobwod commented 2 months ago

It's good to see that this long-standing issue is being brought up.

I think that the logic must go into a few places, notably:

(There might be other cases I’ve overlooked at the moment, as I’m writing off the top of my head.)

Drawer toggle buttons should perhaps just stay "below" on all occasions. I mean: this screenshot clearly illustrates the lack of consistency: Skärmavbild 2024-09-02 kl  11 21 56

Does this mean that a global controller is needed? I don't know. I guess we'll see how things turn out during the implementation phase.

OlofSvahnVbg commented 2 months ago

So I changed the issue a bit. As mentioned above I think changing logic for search and drawerbuttons is enough for now.