This PR specifies the Perl::Critic theme and severity level explicitly so as to avoid other Perl::Critic policies being used unnecessarily in the critic.t tests. The solution implemented here is basically that described by @olof in #14 and solves the problem of the extra, unwanted Perl::Critic violations (which were only those for OTRS anyway). Two solutions are implemented here: a simple, quick fix of the issue by explicitly specifying the Perl::Critic settings in the test file, and a more extensible solution using a perlcriticrc file. I've put these in separate commits so that you can cherry pick them if so desired.
This PR is submitted in the hope that it is useful. If you need any changes to it, please just let me know and I'll updated it and resubmit.
This PR specifies the Perl::Critic theme and severity level explicitly so as to avoid other Perl::Critic policies being used unnecessarily in the
critic.ttests. The solution implemented here is basically that described by @olof in #14 and solves the problem of the extra, unwanted Perl::Critic violations (which were only those for OTRS anyway). Two solutions are implemented here: a simple, quick fix of the issue by explicitly specifying the Perl::Critic settings in the test file, and a more extensible solution using aperlcriticrcfile. I've put these in separate commits so that you can cherry pick them if so desired.This PR is submitted in the hope that it is useful. If you need any changes to it, please just let me know and I'll updated it and resubmit.