search

hako / durafmt

:clock8: Better time duration formatting in Go!
MIT License
496 stars 49 forks source link

previous fix only worked for first year edge case, the new fix should… #9

Closed rolinux closed 6 years ago

rolinux commented 6 years ago

… work for much longer. Please validate as changes were done for weeks calculation also

codecov-io commented 6 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          57     57           
=====================================
  Hits           57     57
Impacted Files Coverage Δ
durafmt.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3df7311...8aac98b. Read the comment docs.

rolinux commented 6 years ago

Sorry for messing up the format of the file, was done in VIM

hako commented 6 years ago

@rolinux It's fine, I use fatih/vim-go when working in vim. It should do gofmt for you. As long as the tests pass it's all good. :)