halcyon / asdf-java

A Java plugin for asdf-vm.
MIT License
468 stars 87 forks source link

Add GitHub Actions workflow for running tests on PRs #31

Closed joschi closed 5 years ago

halcyon commented 5 years ago

Just curious, how does this differ from Travis?

joschi commented 5 years ago

@halcyon Functionally not much, but in my experience GitHub actions are quite a bit faster than Travis CI. Additionally, you don't need a 3rd party service.

Here's how it looks like in a PR: https://github.com/joschi/asdf-java/pull/1/checks

I'm not offended if you decide to not merge this PR. 😉

halcyon commented 5 years ago

@joschi It looks fantastic, and I appreciate the work you've done. I planned to merge, just wanted to be educated (for the future)! Thanks again for all your great work!