search

halestudio / hale-cli

hale command line interface
GNU Lesser General Public License v3.0
1 stars 6 forks source link

Releases have SNAPSHOT strings in download link #149

Open dstenger opened 1 month ago

dstenger commented 1 month ago

Releases >= version 5.2.0 listed here include SNAPSHOT strings in the download link. Is this intentional?

florianesser commented 1 month ago

Hi @dstenger, thanks for bringing this issue to our attention! The SNAPSHOT string in the file name of release artifacts is not intended, we will look into it.

Even worse: for the 5.2.1 release, the file name is also hale-5.3.0-SNAPSHOT.zip.

stempler commented 4 weeks ago

My guess would be that this is caused by a dirty working copy of the Git repo during the release build. So we would need to identify what files cause that problem and probably add them to .gitignore.

stempler commented 4 weeks ago

Looking at the action logs the version was determined correctly, but the issue was that the artifacts were built before the release was done. Should be fixed with the changes in #152

stempler commented 3 weeks ago

Problem remains for existing releases - need to be updated.