halfnelson / svelte-native

Svelte controlling native components via Nativescript
MIT License
1.82k stars 78 forks source link

"resolve.conditionNames" array warning about webpack.config.js #337

Open tonymurray opened 1 year ago

tonymurray commented 1 year ago

When I create a default new Nativescript svelte application: ns create blankapp --svelte cd blankapp && ns debug android

I get a warning: WARNING: You should add "svelte" to the "resolve.conditionNames" array in your webpack config. See https://github.com/sveltejs/svelte-loader#resolveconditionnames for more information

The default webpack.config.js file is:

const webpack = require("@nativescript/webpack"); module.exports = (env) => { webpack.init(env); return webpack.resolveConfig(); };

Following some research/trial-and-error at: https://webpack.js.org/configuration/resolve/#resolveconditionnames I change webpack.config.js to:

const webpack = require("@nativescript/webpack"); module.exports = env => { webpack.init(env) module.exports = { resolve: { conditionNames: ['svelte'], }, } return webpack.resolveConfig() }

...Then the warning goes away. Is this an appropriate solution in relation to the warning?

ghost commented 1 year ago

Thanks for the quick solution, you saved me a lot of time, @tonymurray!

eikaramba commented 1 year ago

you can also just add this: webpack.mergeWebpack({ resolve: {conditionNames:['svelte','require','node'] }})

danawoodman commented 9 months ago

Crazy this is still an open issue, just setup a brand new project and was greeted with this error. Is this something upstream in Native Script or in Svelte Native?