halfwhole / pe

0 stars 0 forks source link

Autocomplete suggestions should adapt to current state in visit #8

Open halfwhole opened 4 years ago

halfwhole commented 4 years ago

The commands visit-cancel, visit-end and visit-now-update only make sense when there is an ongoing visit -- perhaps this should be reflected in autocomplete too, in that they only appear when there's an ongoing visit?

nus-pe-bot commented 4 years ago

Team's Response

Its a good suggestion to improve on the feature but not a critical functionality for auto-completion

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I'd still say that it is a critical functionality -- when there is no ongoing visit, commands such as visit-cancel, visit-end and visit-now-update do not make sense and are invalid commands, so autocomplete should not suggest them and guide the user towards making invalid choices.