search

halfzebra / elm-aframe

:sunglasses: A-Frame bindings for Elm
http://package.elm-lang.org/packages/halfzebra/elm-aframe/latest
29 stars 12 forks source link

Rotation signature should be `Float -> Float -> Float -> Attribute msg` #15

Closed gabrielperales closed 7 years ago

gabrielperales commented 7 years ago

I don't know why you are allowing just integer degrees as parameters here.

halfzebra commented 7 years ago

@gabrielperales thanks for contributing!

I couldn't find any mentions of rotation values being floats in the docs/examples or even in Three.js since it relies on Vector3 if I understand it correctly.

It looks like it's possible to use float values, so this issue makes perfect sense! 👍