search

halfzebra / elm-aframe

:sunglasses: A-Frame bindings for Elm
http://package.elm-lang.org/packages/halfzebra/elm-aframe/latest
29 stars 12 forks source link

added more primitives #31

Closed gabrielperales closed 7 years ago

gabrielperales commented 7 years ago

This pull request keeps your approach. It is just creating a new html node for each primitive but is not checking if the element properties are correct.

I will remove the WIP status as soon as I add comments to all the functions

gabrielperales commented 7 years ago

@halfzebra I think this can be merged, check it out when you have time

halfzebra commented 7 years ago

@gabrielperales looks good to me! Thanks for the PR 👍