search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
843 stars 108 forks source link

[Feature Request] Download and mux font #819

Closed moi15moi closed 11 months ago

moi15moi commented 11 months ago

Is your feature request related to a problem? The mkv produced doesn't contains the font.

Describe the solution you'd like An option to download and mux the font into the mkv. It is needed to display properly the .ass sub

Describe alternatives you've considered I am pretty sure there is an endpoint for the font. It is needed, I can try to look for them.

hama3254 commented 11 months ago

Please check #764, it contains options for the subtitles and has comparisons in it. For me it looks basically like on CR with that.

You should find the ScaledBorderAndShadow: yes on the Output tab of the settings.

moi15moi commented 11 months ago

I don't see how ScaledBorderAndShadow is related to this issue. The issue is about muxing font, not about an problem with the subtitle.

hama3254 commented 11 months ago

I don't see how ScaledBorderAndShadow is related to this issue. The issue is about muxing font, not about an problem with the subtitle.

Your claim why you need the font is:

It is needed to display properly the .ass sub

And that option changes the subs as seen here.

grafik

Which also means you don't need the font.

moi15moi commented 11 months ago

Your player display the subtitle only because you have installed the font into your system.

If you would not have them installed, it wouldn't display the subtitle properly.

This is a common problem for .ass. We always need to mux the font into the mkv.

hama3254 commented 11 months ago

This seems to be some individual problem of you. I checked some subtitles and i see the most default fonts possible. Something like Trebuchet MS or Arial.