search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
843 stars 108 forks source link

Subtitles have an odd size #855

Closed pbz134 closed 8 months ago

pbz134 commented 8 months ago

Describe the bug After downloading a Crunchyroll video with softsubs, the subtitles' size appears too big and oddly stretched. Editing the "PlayResX" and "PlayResY" values in the .ass file manually kind of fixes this issue I attached the subtitles (.zip) here for people to inspect.

Edit: I found out that converting the .ass file to .srt fully fixes this issue, but no way to directly get this file type from the downloader afaik.

Where does the issue happen?

Screenshots grafik YuruYuri PV.zip

Davis092 commented 8 months ago

This happens in new versions of VLC (it happened to me weeks ago).

It shouldn't happen in v3.0.9.2 .

pbz134 commented 8 months ago

This happens in new versions of VLC (it happened to me weeks ago).

It shouldn't happen in v3.0.9.2 .

Thank you! This fixed it! :)

Anonymous327 commented 7 months ago

This happens in new versions of VLC (it happened to me weeks ago).

It shouldn't happen in v3.0.9.2 .

That's actually incorrect if you open the subs in a subtitle editor. The ASSA script resolution is wrong. It's downloaded as 360p instead of 1080p. Even if you open them in a media player that resizes them to fit, they won't look the same as proper 1080p subs. The subtitle resolution should change depending on which video resolution you choose (because the size of subs will change depending on the resolution of the video, of course. This seems like bug that did not exist when I first started using the program. I'm gonna open a new issue to see if people see what I mean...

Discovered that you have to choose "merge disabled" and check "add 'ScaledBorderAndShadow:yes' to subtitles" for the subs to display correctly. With "Copy" enabled, you need to choose hybrid mode to be able to check ScaledBorderAndShadow:yes.

hama3254 explains it better here. https://github.com/hama3254/Crunchyroll-Downloader-v3.0/issues/871#issuecomment-1879675344