search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
843 stars 108 forks source link

"Copy" / Default Subtitle Options are Wrong, Leading to Incorrect Styling and Sizing for .ass Subs #871

Closed Anonymous327 closed 7 months ago

Anonymous327 commented 7 months ago

Describe the bug

After downloading a video with this program, the subtitles, whether soft or external, are not sized or styled properly in a media player. I believe 'ScaledBorderAndShadow:yes' not being checked by default or included in the "Copy" settings is the culprit. Moreover, it chooses the lowest PlayResX/Y resolution (640x360) automatically instead of the actual video size.

Where does the issue happen?

Screenshots VLC: image Plex: image Plex after fixing ASSA resolution: image

Additional context For whatever reason, the subs (copy/merge disabled) always look wrong in VLC, even after doing the fixes.

Edit:

After some further investigation, I discovered that you have to:

  1. Go to Output. Choose merge disabled. "Copy" will not give you the desired options.
  2. Check "add 'ScaledBorderAndShadow:yes' to subtitles".
  3. Subtitles should display correctly now.
  4. (Optional) You can change the resolution to 1080p via notepad or a subtitle editor as well just for completeness, but what this means is you'll have to edit all the subs manually if you want to change the resolution. Can be done with a batch convert, but it's an extra step that we shouldn't have to take, in my opinion...
  5. Merge with video files to create softsubs.
hama3254 commented 7 months ago

I believe 'ScaledBorderAndShadow:yes' not being checked by default or included in the "Copy" settings is the culprit.

The default settings should be as universell as possible. Subtilte options are dependent on your setup (Hardsubs/Softsubs) so i can not enable any settings that changes the output file.

  1. Go to Output. Choose merge disabled. "Copy" will not give you the desired options.

You can enable ScaledBorderAndShadow:yes with MKV on copy if the Hybrid Mode is enable at the top. Why this option does not work otherwise can be found here : https://github.com/hama3254/Crunchyroll-Downloader-v3.0/issues/764#issuecomment-1595774856

Anonymous327 commented 7 months ago

Good to know, thanks. Will take a look.

Anonymous327 commented 7 months ago

I believe 'ScaledBorderAndShadow:yes' not being checked by default or included in the "Copy" settings is the culprit.

The default settings should be as universell as possible. Subtilte options are dependent on your setup (Hardsubs/Softsubs) so i can not enable any settings that changes the output file.

  1. Go to Output. Choose merge disabled. "Copy" will not give you the desired options.

You can enable ScaledBorderAndShadow:yes with MKV on copy if the Hybrid Mode is enable at the top. Why this option does not work otherwise can be found here : #764 (comment)

Though, would still prefer for the PlayResX/Y resolution to be whatever video resolution you choose in the settings, even though it works currently. I imagine that ScaledBorderAndShadow:yes makes it so it doesn't matter what PlayResX/Y resolution it is. So, for example, if you choose 1080, it'll do 1920x1080 for the PlayResX/Y, and so on and so forth. Is it possible to specify that in the script? Or is it locked to 640x360?