search

hampusborgos / country-flags

SVG and PNG renders of all countries' flags.
3.4k stars 968 forks source link

Remove pre-built PNGs #143

Open wyattoday opened 1 year ago

wyattoday commented 1 year ago

Hey @hampusborgos,

A major block in me contributing more lately has been the presence of pre-built pngs in the repository. Every flag with errors requires a ton of work to generate the PNGs for them. I just don't have the time (or patience) to do that extra work.

Would you be OK if I removed the png* folders? Users could still regenerate the sizes they needed, and it would significantly increase the speed and frequency at which I contribute fixes & updates to this repository.

I will start contributing more (starting today), but I definitely will not be touching the PNGs anymore. And rather than have the PNGs and SVGs get more and more out-of-sync, it makes more sense to just nuke the PNGs altogether.

I didn't want to to make this change unilaterally.

hampusborgos commented 1 year ago

Hello, is the script not sufficient to generate the PNGs? Potentially it could run as a GitHub action, so it is automatic.

wyattoday commented 1 year ago

The script has never worked for me. I’m on Windows and use the latest NodeJS.

I briefly considered fixing it to work on Windows, but we have no need for pngs in our org, and it wasn’t a good use of my time.

I’d be on board with a GitHub action that autocommits the png versions of any changes to SVGs.