handshake-org / hsd

Handshake Daemon & Full Node
Other
1.92k stars 278 forks source link

hs-client: move all websocket calls under .ws namespace. #886

Open nodech opened 7 months ago

nodech commented 7 months ago

This makes it easier to reason about the calls. It becomes more explicit - what's going on, whether you need to call .open for a method call to work or not etc.

bindings and etc, other than methods themselves, could also work on the client as they were. But it's recommended to use .ws, makes it easier to read.

coveralls commented 7 months ago

Coverage Status

coverage: 68.619% (-0.007%) from 68.626% when pulling ca10c0a5608c325c2a6aacd3007d8be1d77d9f2a on nodech:hs-client-ws into 5f943173e0b58d6110e6945b3f7ff925ae6dec5c on handshake-org:master.