Please add missing Persian and Urdu characters

[yanone]

Google Fonts has a minimum Arabic glyphset that includes Persian and Urdu. Please see https://github.com/googlefonts/glyphsets/blob/main/GLYPHSETS.md#gf-arabic-core for details.

This is the minimum glyphset that we require for Arabic fonts. Please add the missing glyphs as mentioned in PR https://github.com/haniadnansd/Badeen-Display/pull/2.

Afterwards, I believe the font is almost ready for publication. We will have to talk about a designer profile and font description, but let's go step by step.

Thank you.

[haniadnansd]

Hello Yanone...

Thanks a mil for the help on this... really appreciated.... I've made all the requested amends. and updated the source and otf file.

Please let me know if all is place

[yanone]

Okay. I see you slacked a bit with the Persian/Urdu glyphs. They're partially incomplete. But don't worry, I'll fix it for you.

Also, for next time, you need to merge the PR as opposed to taking the file from the PR and just replacing it in the repository, because I updated not just the source file. I know that using Github is a steep learning curve for some, so we'll do it step by step. For now, don't do anything unless I ask you to.

How are you accessing the files in this repository? Are you using the command line git command, or a GUI tool of sorts, or just directly in the browser?

[yanone]

I find the space a bit narrow for both Arabic and English. I suggest to increase it from 60 to 100 units, see comparison below. Are you okay with that?

Original:

Wider space:

[haniadnansd]

Hello Yanone...

Thanks for the quick response.... you are an absolute legend :)

OMG, Navigating through GitHub is not an easy ride for sure. I'm pretty sure once I get the hang of it, it will make the process way easier. I'm using the web browser to access and upload everything. Apologies if I misplaced some files here and there.

for Persian and urdu I thought I designed the entire glyph set (please check the

attached screenshot). but please feel free to add in anything. I really appreciate that.

In regards for the spacing. yes. I agree with you.. now seeing them side by side it feels a bit tight. so let keep it at 100.

Looking forward for the next steps

Regards Hani

[yanone]

For Persian you added just the base letter in one example, ignoring the .ini/medi/fina variants, some others existed but were left empty. It's all fixed now, and I get paid to do that, so it's no bother.

Now, about Github.

Proper use of Github is part of the trade, like knowing how to operate Glyphs.app. That's just how it is; it's 2024, and Google Fonts definitely requires it.

When I prepare a Pull Request, I fork your repository into my own Github account, so it's like a duplicate. That's because I don't have technical permission to change data in your repository. So then I make those data changes, and then create a Pull Request, which is a request with you to "pull" the changes from my repository back into yours.

(If you have kept editing data in your repository while I also worked on it, there is a chance that we'll run into merge conflicts where conflicting data edits need to be resolved. Conflicts are nasty, so it's best to communicate to avoid working on files at the same time.)

You can review the data changes in the "Files" tab of each PR. Then you either request additional changes from me if you'r unhappy, and otherwise you "merge" the PR which folds my changes back into your own repository. These can be changes to several files at once, like the source file and then also the ttf/otf font files which I've generated using our proper production pipeline that you may not have set up for yourself. We don't use fonts generated with Glyphs.app for quality reasons.

If you happen to have "cloned" your repository onto your computer using a Github client such as the git command line tool or the GUI tool "Github Desktop" (which I use), you would then have to update your local repository clone after a merged Pull Request. You would "pull" the changes from the repository onto your computer, whereas normally you just "push" changes from your computer onto the online repository when you're the only editor around.

When you don't use a local repo clone, the same applies: The data in your computer needs updating, so even if you just work with the .glyphs source and nothing else, you would first have to download the now changed file from the repo back onto your computer, make changes, and push them back to the repository where I and our software can see them.

Read this page about Pull Requests: https://docs.github.com/en/get-started/start-your-journey/hello-world except that we're using whole repo forks, not branches within a repository, but otherwise the process is the same.

Otherwise it's a bit late now, but it appears as tho you never looked at or knew about our guide, which explains everything in (a lot of) detail: https://googlefonts.github.io/gf-guide/

In summary, as a next step, when you receive the next PR from me, open the PR in the browser, review the changes in the different tabs, then "merge" it. If you don't want to make other changes after the merge, just leave everything in place and that's it. We will then pull the TTF font files from your repository to our servers. If you make additional changes to the font after a merge but you're not using our font production pipeline, give me a notice and I'll generate new font files from your updated source, after which we'll the repeat the PR game.

[haniadnansd]

Hi Yanone

I noticed an issue with ain-ar.fina it's missing the right-hand side connection part. I fixed it as the screenshot below. how should I submit the fixed .glyphs file?

[yanone]

Now after you merged the PR, you just change the data on your side as usual, commit the changes to the repository, and when I continue to work on it, I pull the changes onto my clone.

Since you're not at the stage where you can generate the fonts with our toolchain, I would generate the fonts again and make another PR. It feels complicated but you get used to it, and working collaboratively on data needs special care anyway.

Just go over the whole thing once more and make any changes you see fit, then let me know. I'll continue to work on it on Wednesday—Friday.