haniadnansd / Badeen-Display

SIL Open Font License 1.1
1 stars 1 forks source link

Additional changes to prepare publication on Google Fonts #5

Closed yanone closed 1 month ago

yanone commented 1 month ago

I completed the recently added Persian and Urdu characters.

Additionally, I allowed myself to improve the isolated ل and ن shapes. Like their .fina counterparts, these shapes should go noticeably below the baseline. In case of the ن, the same shape as the ب was used, which isn't legible.

Please let me know if I overstepped with these design changes and I'll be happy to revert them.

Also, I removed anchors from composite glyphs. They automatically inherit their anchors from the referenced original glyphs, like they inherit the outlines too.

Before you proceed, please read my comment in the issue on merging PRs.

Then please make sure to merge this PR and continue to work with the updated data on your end, or ask if you have any question about the process.

Thank you.

haniadnansd commented 1 month ago

Hello Yanone....

Thanks again for the help. I'm getting myself more familiar with Github. Appreciate for the detailed walkthrough. For the ل and ن I agree with you. It's better to lower it below the baseline. so thanks for that.

Everything is good to go from my side