search

hannesmann / vanillafixes

Client modification for WoW 1.12.1 to eliminate stutter and animation lag
MIT License
132 stars 15 forks source link

How to use it w/ wowreeb launcher? #3

Closed laytya closed 1 year ago

laytya commented 1 year ago

Could not make it work. example?

hannesmann commented 1 year ago

Looking at the example config (https://github.com/namreeb/wowreeb/blob/master/example_config.xml#L34) it seems like there's an issue with the way wowreeb loads DLLs: It requires an exported method to call in the DLL. VanillaFixes doesn't work this way, instead relying on DLL_PROCESS_ATTACH and DLL_PROCESS_DETACH to modify game code.

I could make a workaround in VanillaFixes by adding an empty placeholder function for wowreeb to call but there's another issue, it only supports loading one DLL per instance. This means VanillaFixes and nampower wouldn't work together if you use wowreeb.

I opened an issue here: https://github.com/namreeb/wowreeb/issues/20. I won't be home until next week but if the issue isn't resolved by then I'll fix it myself and open a pull request for wowreeb.

laytya commented 1 year ago

I m personally dont use nampower, so u can make fix for VanillaFixes to test it work

hannesmann commented 1 year ago

OK, I haven't tested this but it should work: https://github.com/hannesmann/vanillafixes/blob/wowreeb-workaround/bin/VfPatcher.dll?raw=true

Load with <DLL Path="VfPatcher.dll" Method="Load" />.

laytya commented 1 year ago

Its starts now. Thanx

hannesmann commented 1 year ago

Issue has been fixed in wowreeb 3.5.