hansemannn / titanium-firebase-cloud-messaging

Use the Firebase Cloud Messaging SDK in Axway Titanium 🚀 Edit
Other
43 stars 31 forks source link

chore: update android firebase-messaging to 23.1.1 and update Firebase iOS SDK to 10.4.0 #145

Closed jordanbisato closed 11 months ago

jordanbisato commented 1 year ago

Android changes since 23.0.0:

23.0.1:

23.0.2:

23.0.3:

23.0.5:

23.0.6:

23.0.7:

23.0.8:

23.1.1:


iOS changes since 8.12.1:

10.1.0:

10.3.0:

10.4.0:

m1ga commented 1 year ago

Tested the Android version and it works fine :+1: (foreground, background, closed app)

Could you add one thing so we don't need a second PR: https://github.com/hansemannn/titanium-firebase-cloud-messaging/blob/db72a538d7d332534ac5073ac705219b0a999cd6/android/src/firebase/cloudmessaging/TiFirebaseMessagingService.java#L267

to int color = TiConvert.toColor(params.get("color"), TiApplication.getAppCurrentActivity()); so it will get rid of the deprecation warning

jordanbisato commented 1 year ago

Tested the Android version and it works fine 👍 (foreground, background, closed app)

Could you add one thing so we don't need a second PR:

https://github.com/hansemannn/titanium-firebase-cloud-messaging/blob/db72a538d7d332534ac5073ac705219b0a999cd6/android/src/firebase/cloudmessaging/TiFirebaseMessagingService.java#L267

to int color = TiConvert.toColor(params.get("color"), TiApplication.getAppCurrentActivity()); so it will get rid of the deprecation warning

Done!

m1ga commented 1 year ago

Done!

Thanks :+1:

jordanbisato commented 1 year ago

closed in favor of https://github.com/hansemannn/titanium-firebase-cloud-messaging/pull/147

hansemannn commented 1 year ago

@jordanbisato We had a lot of changes recently, so I'm not sure which ones are more recent right now. Could you maybe update to latest again to make sure?

m1ga commented 1 year ago

@jordanbisato and if you update can you please use a version >=10.10.0 as Google will require that version in June 2024 and it would be great to have a compatible version already.

Android counter part is available at https://github.com/hansemannn/titanium-firebase-cloud-messaging/pull/148

hansemannn commented 1 year ago

@jordanbisato I updated to the latest from this week in #149 to update all Firebase modules at once. Hope that's fine!

m1ga commented 11 months ago

I think this might be obsolete now and can be closed, right? But thanks again @jordanbisato I was using the iOS version of it before :+1:

jordanbisato commented 11 months ago

Closed in favor of #148 and #149