search

hapifhir / hapi-fhir-jpaserver-starter

Apache License 2.0
395 stars 1.05k forks source link

Spring-Security #749

Closed nitish-diops closed 1 month ago

nitish-diops commented 1 month ago

@dickson-diops please review Code

XcrigX commented 1 month ago

@nitish-diops - Looks like this PR was submitted against the main project rather than your fork.

KevinDougan commented 1 month ago

Hello @nitish-diops and @dickson-diops,

I don't believe it is appropriate to add Spring Security to the hapi-fhir-jpaserver-starter project. The intention of this project is to be a simple wrapper around the hapi-fhir project, so that you can get up & running as quickly as possible. Note the following in the README: https://github.com/hapifhir/hapi-fhir-jpaserver-starter?tab=readme-ov-file#hapi-fhir-starter-project where it says: "1. The service comes with no security implementation. See how it can be done here"

Therefore, I think you should probably CANCEL this PR.

Thanks, Kevin

nitish-diops commented 1 month ago

Hello Kevin Dougan,

I hope this message finds you well. I would like to sincerely apologize for mistakenly submitting a pull request to the main branch instead of the appropriate forked repository. I understand the importance of adhering to our workflow processes and will ensure that all future submissions are directed to the correct repository. Thank you for your understanding, and I appreciate your support as I work to rectify this matter.

Thanks, Nitish Kumar

From: craig mcclendon @.> Sent: 10 October 2024 18:57 To: hapifhir/hapi-fhir-jpaserver-starter @.> Cc: Nitish Kumar @.>; Mention @.> Subject: Re: [hapifhir/hapi-fhir-jpaserver-starter] Spring-Security (PR #749)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

@nitish-diopshttps://github.com/nitish-diops - Looks like this PR was submitted against the main project rather than your fork.

— Reply to this email directly, view it on GitHubhttps://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/749#issuecomment-2405093351, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BL5XU6B4EAHL27TC6CYWTLDZ2Z6C5AVCNFSM6AAAAABPWHS6ECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGA4TGMZVGE. You are receiving this because you were mentioned.Message ID: @.***>