hapifhir / hapi-fhir

🔥 HAPI FHIR - Java API for HL7 FHIR Clients and Servers
http://hapifhir.io
Apache License 2.0
2.04k stars 1.33k forks source link

Fix tests about elementsSubset #6399

Closed SijieMei closed 4 weeks ago

SijieMei commented 1 month ago

Issue

Following Tests all used method "elementsSubset" of class "GenericClient". ElementsSubset used a HashSet to store URL queries. Since HashSet doesn't guarantee the orders of entries. The URL GenericClient prints will have different String in different times.

Change

I found some tests have the handler for different output String but some test doesn't. I added the handler for these tests missing it.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.52%. Comparing base (406db33) to head (c279aae). Report is 80 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6399 +/- ## ============================================ - Coverage 83.54% 83.52% -0.02% - Complexity 27432 27767 +335 ============================================ Files 1707 1738 +31 Lines 106185 107449 +1264 Branches 13397 13489 +92 ============================================ + Hits 88710 89747 +1037 - Misses 11750 11917 +167 - Partials 5725 5785 +60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tadgh commented 4 weeks ago

Just wanted to chime in saying thank you so much for this contribution! We really appreciate it

fil512 commented 3 weeks ago

Yes thank you so much! Intermittent test failures slow down everybody. So happy for this contribution!