Discover configured devices

[rasathus]

Hello.

Im in the process of looking at the module with a view to implementing discovery of devices on the network.

After looking through the code, I realised that the hard work had already been done, in that it can send discovery requests, and receive the responses.

At the moment the majority of the code is structured under the S20 object, which requires the host details to initialise. I thought I would open this ticket to discuss breaking some of this out, and restructuring it to make it possible to implement discover as a standalone feature.

Does anyone have any thoughts on this ?

[happyleavesaoc]

That's the reason I didn't initially add discovery.

I think it may be worthwhile to have an S20Manager object that would handle the following:

• Discovery
• UDP Socket

This change would move the send/receive functions into the manager, and all S20 objects would share the same manager/socket with a command queue. (which should fix some issues that manifest when you have multiple sockets being controlled at the same time). It would also be a convenient place to do discovery.

The downside is a bit more complexity when using this module.

[rasathus]

Thats along the lines of my initial thoughts.

Do you think the S20Manager should decode the messages to retrieve the host and then hand it off the the relevant S20 object, or should it decode the messages and call the relevant method on the registered S20 object to deal with that type of event ?

[sergiookey]

Thank for your help. For ORVIBO ALLONE R1U? I am interesting a control total with Python.

[happyleavesaoc]

I don't feel strongly a particular way with respect to which class should handle message decode. Intuitively, I'd think that S20Manager would handle decode, since it has to handle at least some decode already, specifically the discovery messages.

[happyleavesaoc]

I'm considering moving _socket to be a module-level variable, accessed with locks. Then extracting the necessary parts of discover to a module-level function. I think this could keep the design simpler.

[happyleavesaoc]

I added discover. It returns a set of host addresses.

[seoyoungjin]

I'm using orvibo switch with homeassistant. I made a fork and commited some changes. Please review. https://github.com/seoyoungjin/python-orvibo Thanks.

• some info added to discover()
• mac argumemt is added to S20.S20() not to call too many DISCOVERY msg

[happyleavesaoc]

I took a look at your commits - nice changes. Can you do a pull request? Then we can merge the commits.

[seoyoungjin]

I created new pull request but I don't know this is right because I'm not good at git. :-) Anyway I'm writing more code.

• get detail device information i.e. device name
• some test code simillar with https://github.com/fernadosilva/orvfms

[happyleavesaoc]

Merged your PR, thanks!