happypandax / plugins

Plugins for HappyPanda X
https://happypandax.github.io/
GNU Lesser General Public License v3.0
32 stars 16 forks source link

detect metadata inside archived files(cbz, zip, etc)? #31

Closed sandriaas closed 4 years ago

sandriaas commented 4 years ago

downloaded via hdoujin, cbz format, metadata in info.txt the metadata can't be detected. is it actually only support folder? thanks before

twiddli commented 4 years ago

No, the files should be detected in archives too, but I think there's a bug (which I've fixed, just waiting for HPX v0.11) where it fails to detect the file if it's in a sub-folder inside the archive.

sandriaas commented 4 years ago

my cbz file are like this. there aren't any folder inside comic-1.cbz

info.txt 01.jpg ......

twiddli commented 4 years ago

What's the content of info.txt? I can and replicate the issue on my end.

sandriaas commented 4 years ago
TITLE: Artist -  CuteSexyRobutts
ORIGINAL TITLE: 
AUTHOR: 
ARTIST: Cutesexyrobutts
CIRCLE: 
SCANLATOR: 
TRANSLATOR: 
PUBLISHER: 
DESCRIPTION: 
STATUS: 
CHAPTERS: N/A
PAGES: 656
TAGS: Artist:Cutesexyrobutts, Female:Dark Skin
TYPE: 
LANGUAGE: Japanese
RELEASED: 
READING DIRECTION: 
CHARACTERS: 
SERIES: 
PARODY: Final Fantasy Xiv, Nier Automata, Pokemon | Pocket Monsters, Street Fighter, The Legend Of Zelda, Xenosaga
URL: https://.......

like this one. i downloaded my comic using hdoujin downloader

if i extract the cbz, and add the folder to hpx library, all the information can be loaded. but if i add the cbz, the info aren't detected.

twiddli commented 4 years ago

if i extract the cbz, and add the folder to hpx library, all the information can be loaded. but if i add the cbz, the info aren't detected.

right, then I'm sure this issue is what I just fixed for the next HPX version.

twiddli commented 4 years ago

I believe this should now be fixed in v0.11.0, if not, then please re-open the issue

sandriaas commented 4 years ago

Hi, thank you so much for your works on the update. i just tried it, but it's still doesn't work. it's always giving same error like before

Sep-09 12:52:54--INFO pluginctx.file-metadata.main: Attempting with DataType.hdoujin Sep-09 12:52:54--INFO pluginctx.file-metadata.main: DataType.hdoujin didn't match Sep-09 12:52:54--INFO pluginctx.file-metadata.main: Attempting with DataType.e_hentai_downloader Sep-09 12:52:54--INFO pluginctx.file-metadata.main: DataType.e_hentai_downloader didn't match

here's one of the file that i tried. i've been wondering if it's an issue within my own system or not. hope that's not the case 😄

twiddli commented 4 years ago

this should now be fixed in File Metadata v2.0.1