fix(kubernetes-ingress): limit template spec name to 15 characters

haproxytech / helm-charts

Helm chart for HAProxy Kubernetes Ingress Controller

Apache License 2.0

155 stars 121 forks source link

fix(kubernetes-ingress): limit template spec name to 15 characters #247

Closed bmailhe closed 5 months ago

bmailhe commented 5 months ago

This modification introduces two changes in templates:

remove suffix -tcp on template controller.service.tcpPorts's name. Users add this suffix themselves if it's relevant to them.

limit length to 15 characters max according to RFC6335. Avoid errors like:

Error: UPGRADE FAILED: cannot patch "release-name" with kind Deployment: Deployment.apps "release-name" is invalid: [spec.template.spec.containers[0].ports[6].name: Invalid value: "name-too-long-tcp": must be no more than 15 characters

dkorunic commented 5 months ago

PR looks good except that this might cause service name to end up with hyphen which is not allowed. Please change code to {{ .name | trunc 15 | trimSuffix "-" }} or let me know if you want me to edit your PR.