search

hardillb / TRADFRI2MQTT

MQTT Bridge for IKEA TRÅDFRI Light Gateway
https://www.hardill.me.uk/wordpress/2017/04/06/fist-pass-tradfri-mqtt-bridge/
Apache License 2.0
81 stars 12 forks source link

Implement color changing #3

Closed r41d closed 7 years ago

r41d commented 7 years ago

Better merge my other pull request with the Tradfri Constancts first, as this builds on top of it

hardillb commented 7 years ago

Change color to temperature as we don't know if IKEA will release RGB bulbs in the future

r41d commented 7 years ago

Now that you mention it, the COLOR_X and COLOR_Y may be for actual RGB color. Will do that change soon...

r41d commented 7 years ago

OK, I changed it to temperature. I retained the variable name COLOR in the Constants, because it's called like that in the IPSOObjects class from the official Tradfri Anrdoid App.

hardillb commented 7 years ago

I'm just about to add a license to this lot (Apache-2.0) and I'm a bit wary of the constants file, which as it stands the comment at the top basically says it was ripped off from the IKEA Android app, which we have to assume is not Open Source licensed.

Also the long stack of unused constants doesn't help with claiming it was built from available info to do what was needed.

r41d commented 7 years ago

Not sure how much intellectual property a random collections of numbers contains (some also come from official standardization documents) but I mostly aggree on that one. I'm personally fine with Apache 2 License for my submitted code. What would you suggest? One way to do it is kicking all unsed constants and including them one by one, if needed. They are all contained for reference here

hardillb commented 7 years ago

Trim the extra ones, we can add what we need later and maybe try to be a little subtler with the header comment. Then it all looks good and I'll merge.

r41d commented 7 years ago

Hope I achieved subtler :)