haringsrob / CollabApp

An alternative Slack client written in Swift, optimized for Mac
66 stars 6 forks source link

Couple of suggestions #2

Closed esttorhe closed 6 years ago

esttorhe commented 6 years ago

Hi man!

Great way to learn a new language! Major kudos to you.

I just wanted to point out a couple of suggestions for the project (not the code).

I know that is still under development but maybe making «tagged» releases and uploading the zip binary to them would be better; that way you can point people to specific versions and they can even download older versions (for whatever reason they might need to).

Another small suggestion; since you are using CocoaPods would be to include it via a Gemfile and locking the version of CocoaPods; that way you can (perhaps not guarantee) but enforce contributors to use the same version of the tool and prevent possible conflicts.

I hope this doesn't sound like I'm on a high horse; I just thought that perhaps you could use this tips; if not, feel free to toss them aside 😄

All in all great job 👍

haringsrob commented 6 years ago

Hi, thank you for the feedback, it is appreciated.

As you can see the project is not updated in about 6 months, main reason being that there is too much to be done for 1 person only.

However, if I pick up development again, I will improve with your guidelines. It's not easy to know those best practices when you are not a main swift developer.

esttorhe commented 6 years ago

Actually I failed to check the last time you updated the repo 🙈

😄 Thanks for being such a good sport; and good luck with the project

haringsrob commented 6 years ago

Hi esttorhe, I am picking up development again, could you suggest on how to make proper releases?

It seems that you have more experience than me.

haringsrob commented 6 years ago

Hi @esttorhe releases are now on the release page.