harlowja / fasteners

A python package that provides useful locks.
Apache License 2.0
243 stars 45 forks source link

RFE: allow build with latest `setuptools` > 60 #84

Closed kloczek closed 2 years ago

kloczek commented 2 years ago

Looks like 0.17.1 forces to use exact version of the setuptools.

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...
running egg_info
creating fasteners.egg-info
writing manifest file 'fasteners.egg-info/SOURCES.txt'
writing manifest file 'fasteners.egg-info/SOURCES.txt'

ERROR Missing dependencies:
        setuptools==57.0.0

I've tested below patch:

--- a/pyproject.toml~   2022-01-17 11:43:19.000000000 +0000
+++ b/pyproject.toml    2022-01-17 13:02:58.194551517 +0000
@@ -1,3 +1,3 @@
 [build-system]
-requires = ["setuptools==57.0.0", "wheel"]
+requires = ["setuptools>=57.0.0", "wheel"]
 build-backend = "setuptools.build_meta"

Ans build with latest setupttols > 60 is fine

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...
running egg_info
creating fasteners.egg-info
writing manifest file 'fasteners.egg-info/SOURCES.txt'
writing manifest file 'fasteners.egg-info/SOURCES.txt'
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/fasteners
copying fasteners/__init__.py -> build/lib/fasteners
copying fasteners/_utils.py -> build/lib/fasteners
copying fasteners/lock.py -> build/lib/fasteners
copying fasteners/process_lock.py -> build/lib/fasteners
copying fasteners/version.py -> build/lib/fasteners
creating build/lib/fasteners/pywin32
copying fasteners/pywin32/__init__.py -> build/lib/fasteners/pywin32
copying fasteners/pywin32/pywintypes.py -> build/lib/fasteners/pywin32
copying fasteners/pywin32/win32con.py -> build/lib/fasteners/pywin32
copying fasteners/pywin32/win32file.py -> build/lib/fasteners/pywin32
running egg_info
writing manifest file 'fasteners.egg-info/SOURCES.txt'
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/fasteners
creating build/bdist.linux-x86_64/wheel/fasteners/pywin32
running install_egg_info
Copying fasteners.egg-info to build/bdist.linux-x86_64/wheel/fasteners-0.17.1-py3.8.egg-info
running install_scripts
Successfully built fasteners-0.17.1-py3-none-any.whl
psarka commented 2 years ago

Thanks a bunch, was experimenting with some stuff and left it by mistake :man_facepalming:

psarka commented 2 years ago

Released 0.17.2 with a fix, should be ok now.

kloczek commented 2 years ago

Released 0.17.2 with a fix, should be ok now.

No git tag for that version. Probably content of your repo not pushed to github 😄

kloczek commented 2 years ago

Nevertheless .. thank you 😄