search

haroldadmin / MoonShot

A SpaceX companion app for Android
161 stars 18 forks source link

Migrate to Epoxy v4 #30

Closed haroldadmin closed 4 years ago

haroldadmin commented 4 years ago

The latest release of Epoxy supports incremental annotation processing. Migrate the app to Epoxy v4 to benefit from faster compilation times.

mrwhoknows55 commented 4 years ago

@haroldadmin I would like to work on this issue. Do you expect any issues after updating epoxy to v4?

haroldadmin commented 4 years ago

I am not sure, I haven't been following the changelog very closely. Its quite likely though, as MoonShot uses Epoxy extensively.

mrwhoknows55 commented 4 years ago

what are your suggestions on same?

haroldadmin commented 4 years ago

A good place to start is to increment the version number of the dependency, and then sync + rebuild the project. Look out for any compilation errors or new warnings.

mrwhoknows55 commented 4 years ago

thank you @haroldadmin . I'll open PR once hacktoberfest starts ✌

mrwhoknows55 commented 4 years ago

thanks @haroldadmin for assigning it to me. It worked fine after updating the dependency version to 4.0.0 from Versions.kt file from buildSrc module. Is this right?

haroldadmin commented 4 years ago

Yes, that should do it. If there were no compilation errors or additional warnings, please go ahead with the pull request.