View refactorings - Githubissues

haru / redmine_code_review

70 stars 29 forks source link

View refactorings #8

Open jkraemer opened 6 years ago

jkraemer commented 6 years ago

This PR addresses a few potential security problems due to usage of raw and lack of javascript escaping:

replaces all usages of the raw helper in views with safer alternatives.
introduces Javascript-escaping via the j helper.

Also some general refactorings:

extracted the progress_for_changeset helper method
re-used the existing show_assignments helper in another place
removed controller and request context arguments as these do not needed to be passed around like this

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 87.613% when pulling 40143ef6ae6456fab65cfe80a1173f3594a608ce on planio-gmbh:view-refactorings into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.