harvard-lil / capstone

CAP database scripts.
MIT License
189 stars 44 forks source link

Rek alter volume fields #2153

Closed kilbergr closed 1 year ago

kilbergr commented 1 year ago

This PR adds and removes requested fields from VolumeMetadata json. There's some back and forth recorded in the ticket regarding what should be included.

Based on his response, may have to alter this PR.

It's based off this PR and when that lands, will look significantly less complicated.

I am a little unsure what to do here: https://github.com/harvard-lil/capstone/pull/2153/files#diff-b957af52fc247bd70b117433d1fb7fbdf64bdbff62ce5259934ffa1323f6c4d2R267 I think no nominative_reporter dict should be made if there is no nominative_reporter, but I'm not sure whether it's more consistent to have an empty dict. I would like your opinion!

codecov[bot] commented 1 year ago

Codecov Report

Merging #2153 (c0daf7b) into experimental (8151041) will decrease coverage by 0.14%. The diff coverage is n/a.

@@               Coverage Diff                @@
##           experimental    #2153      +/-   ##
================================================
- Coverage         62.36%   62.23%   -0.14%     
================================================
  Files               107      107              
  Lines             11724    11749      +25     
================================================
  Hits               7312     7312              
- Misses             4412     4437      +25     

see 1 file with indirect coverage changes